search

mbari-org / vars-gridview

VARS GridView is a tool for reviewing and correcting VARS localizations in bulk.
MIT License
2 stars 0 forks source link

Use bulk annotation/association endpoints for updates/deletes #51

Open kevinsbarnard opened 1 year ago

kevinsbarnard commented 1 year ago

VARS GridView currently does one request per update/delete of bounding box annotation data. This should be swapped out for the bulk update/delete endpoints for efficiency.

hohonuuli commented 1 year ago

There's a an existing one at POST anno/v1/associations/bulk that accepts a body with an array of Association data (as json)

kevinsbarnard commented 1 year ago

Thanks @hohonuuli! You're right, I misspoke today in the meeting and just looked over the annosaurus code. Not sure why I didn't implement these before. I will use PUT anno/v1/annotations/bulk for annotation updates and PUT anno/v1/associations/bulk for association (bounding box data) updates.

hohonuuli commented 1 year ago

One more detail ... anno/v1/annotations/bulk will only change information in the imaged_moments and observations tables. Any changes to image_references or associations is ignored. (That's intentional BTW)

kevinsbarnard commented 1 year ago

Good to know -- Gridview should only be changing the observation concept via anno/v1/annotations/bulk.

kevinsbarnard commented 11 months ago

Blocked by https://github.com/mbari-org/vars-feedback/issues/82

hohonuuli commented 11 months ago

Found the issue. I've patched it in code and will release a fix tomorrow.

hohonuuli commented 11 months ago

Got delayed a bit dealing with an upgrade to Scalatra 3/Jetty 11. They're resolved now and integration testing looks good. I've pushed a new release as annosaurus 0.16.0. New release has been deployed internally.

lonnylundsten commented 1 month ago

@kevinsbarnard Looks like this may be OK to close as completed?