search

mbari-org / vars-gridview

VARS GridView is a tool for reviewing and correcting VARS localizations in bulk.
MIT License
2 stars 0 forks source link

Improve error handling and presentation on request failures #57

Closed kevinsbarnard closed 11 months ago

kevinsbarnard commented 12 months ago

Exceptions encountered during HTTP requests are currently raised but unhandled. This results in unexpected behavior, a lack of an error message in the logs (the Python traceback is simply printed to stderr), and no apparent error to the user if they are not watching the terminal.

This should be improved to:

  1. Fully define the resulting behavior (ensure views do not represent failed changes)
  2. Catch and log errors
  3. Show an error dialog where appropriate

On a related note, the HTTP client system could be improved to handle (refresh) expired JWT tokens.