search

mbari-org / vars-gridview

VARS GridView is a tool for reviewing and correcting VARS localizations in bulk.
MIT License
2 stars 0 forks source link

Zoom out on framegrab when new localization selected in gridview on left (issue is with two or more localization on same framegrab) #64

Open kwalz opened 11 months ago

kwalz commented 11 months ago

In gridview, when we click on a localization in gridview on left, the framegrab view should zoom out to full frame (upper right). This should hold true for localizations made on the same frame as well. Attached is an example of localization where I am clicked on one, zoomed in in framegrab view then clicked on next localization in that image and gridview did not zoom out on same framegrab.

Screenshot 2023-12-11 at 12 03 09 PM

Hard to type this issue, I can show if needed.

kevinsbarnard commented 11 months ago

@kwalz, this was changed in v0.4.2 as I had originally (from v0.3.9) set up the autoranging (zooming in/out to fit the full frame) to be applied when a localization is selected, but there was an issue on the VARS-ML-SE-tasks (item 31, "Gridview jumping to full frame unexpectedly.") that indicated this was unexpected behavior:

Gridview preview window snaps to full frame if you click inside the ROI. This is not the action we would expect.

Since v0.4.2, the image view only autoranges when the image changes. Do we want to revert this change?

kwalz commented 11 months ago

@kevinsbarnard Hi Kevin, no to revert :) we definitely want it as it was fixed for localizations from different framegrabs. If it's not possible to have it for different ROI gridview selections then let's set this one aside for the new Gridview replacement and we can brainstorm on ways to achieve this. Perhaps we double click on an ROI in gridview on left and that brings the image back to full size in framegrab view.

kevinsbarnard commented 11 months ago

Roger that, I'll keep that behavior in for now, and I think I could make the double-click work! On that note, I'm wondering: do you think it would be better if the double click zooms to the selected localization in the image view, instead of zooming out to the full frame? Happy to do it either way, but I figure that might help so you wouldn't need to then zoom in to the selected localization after it zooms out to the full frame.

kwalz commented 11 months ago

Kyra and I are discussing, let's talk in the next meeting about how we can optimize. We'll think about how it may work as we are cleaning up things in the lab today and tomorrow.

lonnylundsten commented 2 months ago

@kwalz @kevinsbarnard This is done, correct?

kwalz commented 2 months ago

@lonnylundsten This was tabled for the next version of Gridview as well.