search

mbasaglia / Qt-Color-Widgets

Color wheel widget and dialog for Qt
147 stars 54 forks source link

Improved color change in the color_wheel's selector #27

Closed lupoDharkael closed 7 years ago

lupoDharkael commented 7 years ago

The color selector wasn't looking good. It was black in almost the 60/70% of the area. With this change I've expanded the area where the selector is white. The colors in the new defined range are pretty dark or not very light so it implies more contrast and better visibility.

mbasaglia commented 7 years ago

Hmm, I'm not entirely convinced of this change, the darker ring looks better around the edges: screenshot_20170528_091954

Do you have examples where this is not the case?

lupoDharkael commented 7 years ago

well, I use a dark theme in my system and it looks pretty good with the white selector and the black selector was looking as bad as the white one in your capture.

I think the most elegant way to solve this is retrieving the background color with palette() in the constructor and show more or less white based on that. It could be saved as a boolean flag.

if (backgroundIsDark) { // my code with more white } else { // the same code as you have right now }

What do you think? I'll implement this in my project and I want to share these changes with the original code.

mbasaglia commented 7 years ago

Looks good to me, thanks!