search

mbatoul / sklearn_benchmarks

Comparative benchmarking library for scikit-learn's estimators
https://mbatoul.github.io/sklearn_benchmarks/
0 stars 1 forks source link

Try to use sklearn-onnx and sklearn dev #23

Open ogrisel opened 2 years ago

ogrisel commented 2 years ago

Try to run the benchmarks on the dev version of scikit-learn.

ogrisel commented 2 years ago

We now have a problem with scikit-learn-intelex that does not handle the new Cython loss module now used in LogisticRegression.

[...]
   File "/usr/share/miniconda/envs/sklbench/lib/python3.8/site-packages/daal4py/sklearn/__init__.py", line 17, in <module>
    from .monkeypatch.dispatcher import enable as patch_sklearn
  File "/usr/share/miniconda/envs/sklbench/lib/python3.8/site-packages/daal4py/sklearn/monkeypatch/dispatcher.py", line 30, in <module>
    from ..linear_model.coordinate_descent import Lasso as Lasso_daal4py
  File "/usr/share/miniconda/envs/sklbench/lib/python3.8/site-packages/daal4py/sklearn/linear_model/__init__.py", line 19, in <module>
    from .logistic_path import logistic_regression_path, LogisticRegression
  File "/usr/share/miniconda/envs/sklbench/lib/python3.8/site-packages/daal4py/sklearn/linear_model/logistic_path.py", line 37, in <module>
    from sklearn.linear_model._logistic import (
ImportError: cannot import name '_logistic_loss_and_grad' from 'sklearn.linear_model._logistic' (/usr/share/miniconda/envs/sklbench/lib/python3.8/site-packages/sklearn/linear_model/_logistic.py)

I will report upstream.

ogrisel commented 2 years ago

I will report upstream.

Done in https://github.com/intel/scikit-learn-intelex/issues/979.

Let me keep this PR open. We might try to install the dev version of scikit-learn with the fix for the above problem when available.