search

mbatoul / sklearn_benchmarks

Comparative benchmarking library for scikit-learn's estimators
https://mbatoul.github.io/sklearn_benchmarks/
0 stars 1 forks source link

Small reporting improvements #24

Closed ogrisel closed 2 years ago

ogrisel commented 2 years ago

In particular I removed the target="_blank" that I find very annoying (it's easy to ctrl-click or middle-click if one wants to open a specific report in a new tab).

I also changed the quoting style of the HTML tags to make them more standard.

Also I removed the use of Path for URLs. Path objects are only useful for local filesystem path manipulation, not URLs.

Speaking of URLs, @mbatoul have you considered using relative URLs everywhere instead of using absolute URLs? I don't want to make this change as part if this PR but I think it would make the code easier to maintain instead of relying on environment variables.

ogrisel commented 2 years ago

@mbatoul this one should be ready to merge.

mbatoul commented 2 years ago

Thanks @ogrisel!