search

mbattyani / cl-pdf

CL-PDF is a cross-platform Common Lisp library for generating PDF files.
Other
115 stars 41 forks source link

Specialize PDF-PARSE-ERROR #18

Closed phoe closed 3 years ago

phoe commented 3 years ago

Currently the code for CL-PDF defines a root error class named pdf-parse-error and uses it in multiple distinct contexts, only passing different message arguments to it. It might be better to create specialized subtypes of this error type, export their names and accessors, and use them throughout pdf-parser.lisp.

adlai commented 3 years ago

@phoe please close this issue, unless #19 is not sufficient.

ok, ok, you want the condition names to be exported symbols

phoe commented 3 years ago

Oh! I wasn't aware of #19 - yes, it sounds good. Thank you!

adlai commented 1 year ago

Here are found some examples that can help when sketching out the conditions that should always be signalled by the parser, although might not be considered errors if the document is going directly to print.