search

mbax / VanishNoPacket

Invisibility for sexy people.
http://dev.bukkit.org/projects/vanish/
GNU General Public License v3.0
135 stars 113 forks source link

Double-Sneak changes gamemode while in vanish #706

Closed AlessioGr closed 2 years ago

AlessioGr commented 2 years ago

Video of it: https://www.youtube.com/watch?v=y6X1FVgFeMw

This is configurable in the double-sneak-during-vanish-toggles-gamemode config setting.

underscore11code commented 2 years ago

In my opinion this should default to false - F3 + n exists already to switch gamemode between gmc and gmsp, plus this is a fairly intrusive modification to a keybind.

AlessioGr commented 2 years ago

@underscore11code Done! It defaults to false now.

AlessioGr commented 2 years ago

Several comments made, but here's a general one:

Calling this "toggle gamemode" is strange when it really just switches you from whatever you were to spectator, and then doesn't switch back but rather gives you creative. This feels 100% targeted at a specific server rather than targeted at general users.

Plus, if you're going to switch to spectator, that isn't even a vanish plugin thing anymore you're just creating a system for being a spectator. Wat.

Everything should be fine now. It now also remembers your game mode.

This kind of functionality is enabled by default in the plugin "PremiumVanish". As I switched to vanishnopacket, I really miss this functionality. It's pretty useful in a vanish plugin. Say you are vanish next to a player, trying to stalk them. And that player then walks into a house and closes the door. How do you get in that house? With this double-shift functionality, I can just quickly double-shift, fly through that wall and then double-shift back to my last game-mode. It's incredibly useful if you have used it for a while.

Since it's toggled off by default now anyways, it definitely wouldn't hurt anyone.

AlessioGr commented 2 years ago

Also while you're at it could you rebase to latest? :D

I rebased it!

AlessioGr commented 2 years ago

I added the persistentdatacontainer - it should be ready now

mbax commented 2 years ago

https://github.com/mbax/VanishNoPacket/commit/18a39ee5b8e3980bd2b1ba19d1a867b20f69850f