mbax / VanishNoPacket

Invisibility for sexy people.
http://dev.bukkit.org/projects/vanish/
GNU General Public License v3.0
135 stars 113 forks source link

vanish.nopickup not working? #712

Open Globlox247 opened 2 years ago

Globlox247 commented 2 years ago

hi again, i've got most of the vanish plugin to work, but none of the permissions like vanish.nopickup or vanish.nointeract work. how could i fix this?

thanks!

edit: i have them set to true for myself, but then i can still pickup and interact with things.

JordanPlayz158 commented 1 year ago

I have confirmed this issue as well, running Paper 1.18.1 build 216 (latest Paper 1.18.1 build) on Java 17

openjdk version "17.0.7" 2023-04-18
OpenJDK Runtime Environment (Red_Hat-17.0.7.0.7-4.fc38) (build 17.0.7+7)
OpenJDK 64-Bit Server VM (Red_Hat-17.0.7.0.7-4.fc38) (build 17.0.7+7, mixed mode, sharing)

using the latest VanishNoPacket build from bukkit (v3.22) and the permission plugin this was tested with was LuckPerms v5.4.98

It is notable that there is one that is still working: vanish.notrample - This permission did indeed prevent crops from being trampled when you have it

Partially working: vanish.nointeract - I could still place and break blocks while in vanish with this permission but... with my assumption that "block touching" meant something like moving minecarts, it did prevent me from moving a minecart butttt whether or not I had the nointeract permission, I could not move the minecart in vanish regardless of that permission (I could move the minecart out of vanish fine) vanish.preventincomingdamage - I can still take fall damage and "direct" damage (zombie hitting me) regardless of having this permission while in vanish but... I don't take any damage from projectiles regardless of this permission while in vanish (think that is important to note)

The following do not work: vanish.nofollow - tested with zombie while in vanish in survival mode, they could track and followed me, or for llamas when aggroed, they can spit at me vanish.nopickup - regardless of permission, I can always pickup items in vanish vanish.nochat - regardless of permission, I can chat in chat while in vanish vanish.nohunger - regardless of permission, I can eat food to raise my hunger or run in survival to lose hunger vanish.preventoutgoingdamage - regardless of permission, I can deal damage to mobs (such as a chicken), given the wording of "Prevent hurting others", I assume it means all entities but it could mean players (I did not test if I could do damage to players) vanish.preventdamage - expectedly, this does not work as the individual damage permissions do not either vanish.silentchests - regardless of permission, this does not silently open chests and the contents are not read-only (I can modify them)

I stopped here as I rejoined the server to test the vanish.joinvanished permission and I think this problem stems from the VanishNoPacket plugin only checking the permissions of the user on join and does not check throughout with each action performed so in order to fix, perhaps there is a user permission changed event or check the user permissions on each action to fix this issue