mbax / VanishNoPacket

Invisibility for sexy people.
http://dev.bukkit.org/projects/vanish/
GNU General Public License v3.0
135 stars 113 forks source link

3.0 fails entirely #88

Closed viveleroi closed 12 years ago

viveleroi commented 12 years ago

We updated to 3.0, removed spout, and are using CraftBukkit version git-Bukkit-1.1-R3-13-gb3c56b8-b1914jnks (MC: 1.1) (Implementing API version 1.1-R4-SNAPSHOT) - and we're seeing that plenty of players without hacked clients are able to see us when vanished. There are players who can't see us, but I've seen plenty who are able to see us without issue.

A lot of my moderators are reporting that mobs are also not ignoring you. I don't know what happened, but this is even worse than VanishNoPickup now.

mbax commented 12 years ago

List your plugins. Please don't jump to conclusions.

rmsy commented 12 years ago

Did you check the console for errors? Was the plugin functioning in-game? If not, you're probably doing something wrong. And just as a side note, no one can see you whilst vanished, even users with hacked clients (which is why this project was created in the first place).

viveleroi commented 12 years ago

There are no errors on the console and I'm not jumping to conclusions. We've had the same plugins for a long time and the only updates recently have been for this plugin and bukkit itself, so it's either vanish, or bukkit. In vanish mode I tp'd to a player and they starting talking to me locally, they knew I was there. I asked if they could see me and they could. They have permissions to see us, and before 3.0 they could not.

mbax commented 12 years ago

Please, as I requested before, list your plugins.

jamietech commented 12 years ago

"They have permissions to see us" <-- I found your problem.

viveleroi commented 12 years ago

That was obviously a typo, only moderators and above have permissions to see vanished players, and it's been working with permissions unchanged for seven months. Now with 3.0, players are telling me that they see me, or saw me briefly. Yesterday I tp'd to a player and could tell I wasn't seen, but soon they were reporting that had seen me briefly, but couldn't now.

Plugins:

Plugins: FoundBoxx, MultiInv, WorldEdit, dhmcDeath, HeroChat, Vault, PermissionsEx, Multiverse-Core, Questioner, NoAFK, Jail, RemoteToolkitPlugin, OddItem, AutoMessage, Lottery, ModTRS, iConomy, Register, craftys, Permissions, CommandHelper, xWarp, OpenInv, mcbans, InventorySort, MoveInventory, finance, CommandLogger, mcMMO, Essentials, Residence, dhmcStats, WorldBorder, Towny, EssentialsSpawn, CreativeGates, Multiverse-NetherPortals, LWC, dynmap, MobBounty, HawkEye, ChestShop, Dynmap-Towny, VanishNoPacket

mbax commented 12 years ago

There have been reports of this sort of visibility flickering with certain plugins that mess with packets, such as MobDisguise, which you don't seem to have. Before I do more neurotic checking, do you happen to know if any of those change player visibility?

viveleroi commented 12 years ago

They shouldn't - I make an effort to avoid any of those types of plugins. I keep all of those plugins updated as well as I can, so they're all running latest versions except for McMMO which has some severe bugs in 1.2.09+, so we're on 1.2.08.

I can't tell if it's related or not, but we've always had to teleport to people first. Our server is large enough that I'm sure mods have noticed this issue without a prior tp, but in my tests I've always had to use tp to get near people. It's never consistent though, sometimes people can't see me as expected, sometimes they see me for a brief moment, and sometimes I'm entirely visible.

mbax commented 12 years ago

You seem to have a strange case. Several large servers have done a lot of testing and haven't experienced this. The code is designed such that nothing changes on teleport; you're still hidden from all awareness of the player. I won't be able to help immediately with this, I have a busy schedule today, so if you want some quicker testing to solve your troubles, set up a test server where you selectively enable/disable plugins until the issue goes away, to see what's causing it.

rmsy commented 12 years ago

I remember that this used to be an issue with the old Vanish plugin; someone vanished would teleport to a player, and the vanished player would be visible to the user for around a fraction of a second.

mbax commented 12 years ago

Yes, and it's not possible under the new system, by the code.

quickclay commented 12 years ago

I have seen the same issues on my server. (ticket posted as The Ghosts are Back) I am comparing your plugins to mine. Shared plugins are: Worldedit, Vault, Herchat, Pex, iConomy, Mcbans, Essentials, Residence, LWC, Dynmap, and MobBounty.

mbax commented 12 years ago

@quickclay what about your other plugins. :P

mbax commented 12 years ago

Nevermind on that. @quickclay your problem is MobDisguise. Apparently it can't even be on the server at all at the same time as VanishNoPacket if descriptions from other users are correct. Apparently MobDisguise does some stuff that makes baby craftbukkit cry.

viveleroi commented 12 years ago

He didn't list MobDisguise? Were you looking at MobBounty?

mbax commented 12 years ago

He did, on his full list - https://github.com/mbax/VanishNoPacket/issues/87#issuecomment-3899277

quickclay commented 12 years ago

Ah, ok well I can remove Mobdisguise, but is that a new issue? It worked fine with Mobdisguise on the previous version (2.4.1).

mbax commented 12 years ago

Previously, VanishNoPacket would filter out the MobDisguise extra packets that it sent, but with 3.0 VanishNoPacket no longer fixes the MobDisguise issues so they become a visible issue.

andrewkm commented 12 years ago

Just use 2.4.1 for now. There are some compatibility issues with MD im assuming. Once 2.4.1 breaks then we'll worry :P - Either that or just remove MD.

Im staying on 2.4.1 for now untill/if ever it totally breaks.

mbax commented 12 years ago

3.1 is expected to resolve issues reported with this.

quickclay commented 12 years ago

FYI - removing Mobdisguise did resolve this issue.