Closed BlaZZZed1980 closed 3 years ago
Thanks for reporting this!
The fix here might be ensuring the INPUT
value is empty when first calling the STTROU
during an Rlogin session. This would discard any extra data that came in along with the Rlogin session beyond the actual handshake.
I have a WG 3.3 setup I can test this with and report back 👍
I would also be happy to install any experimental build that attempts to correct this issue and report back with the results. I have changed my configuration to Rlogin directly to the MBBSemu menu (where the unwanted characters still appear) but at least then when you enter the modules, everything works normally.
I just added a pull request that I think will fix this. It just depends on if someone knows something I don't about "extra" handshake bits.
@BlaZZZed1980 could you please try one of these builds: https://www.mbbsemu.com/Downloads/master/021121 and let us know here if that fixes the issue for you?
Will do....at work now but will try when I get home. The extra stuff I believe is WG sending screensize info in the header instead of how it's supposed to do it. At least that's how it's been explained to me. I will test this build shortly and report back.
On Thu, Feb 11, 2021 at 1:35 PM synacktic notifications@github.com wrote:
@BlaZZZed1980 https://github.com/BlaZZZed1980 could you please try one of these builds: https://www.mbbsemu.com/Downloads/master/021121 and let us know here if that fixes the issue for you?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mbbsemu/MBBSEmu/issues/130#issuecomment-777738021, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARBCF3JENF3LKHVTLCGGXFDS6QWOZANCNFSM4RQLRHJA .
-- Brian J. Morgan President BlaZZZed Lighting blazzze@gmail.com
I just tested it for him and it is still occuring.
To be clear, this is using RLOGIN with a -a -m switch and mbbsemu-win-x64-021121-4.zip
The following was logged to Audit trail:
2021-02-12 08:56:16.4618 Info MBBSEmu.Server.Socket.SocketServer.OnNewConnection Accepting incoming Rlogin connection from 192.168.10.203:1023...
2021-02-12 08:56:16.4618 Info MBBSEmu.HostProcess.MbbsHost.AddSession Session 192.168.10.203:1023 added to incoming queue
2021-02-12 08:56:16.4618 Info MBBSEmu.Session.Rlogin.RloginSession.ProcessIncomingByte Rlogin For User: Frank.Dux
2021-02-12 08:56:16.4618 Debug MBBSEmu.Session.Rlogin.RloginSession.ProcessIncomingClientData Ignoring extra rlogin data: " "
2021-02-12 08:56:16.4618 Info MBBSEmu.HostProcess.MbbsHost.WorkerThread Added Session 192.168.10.203:1023 to channel 0
2021-02-12 09:02:38.6158 Info MBBSEmu.HostProcess.MbbsHost.RemoveSession Removing Channel: 0
Well boo. I was hoping that was a two birds one stone thing.
Thanks for looking into this issue. It's one that will affect any version of the Worldgroup Rlogin client. Rick Parrish solved it in Gamesrv, so perhaps he has additional details that could help.Sent from my Verizon, Samsung Galaxy smartphone -------- Original message --------From: synacktic notifications@github.com Date: 2/11/21 4:17 PM (GMT-06:00) To: mbbsemu/MBBSEmu MBBSEmu@noreply.github.com Cc: BlaZZZed1980 blazzze@gmail.com, Mention mention@noreply.github.com Subject: Re: [mbbsemu/MBBSEmu] [MBBSEmu] RLogin - Worldgroup 3.x - Sends set of characters on connect (#130) Well boo. I was hoping that was a two birds one stone thing.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
Didn't I hear on the grapevine that it may be attributed to the RLOGIN something something screen size?
Going to be testing the PR now that I have a setup where I can replicate the issue:
@BlaZZZed1980 PR was just merged into main. Try the latest with adding the new additional config option Rlogin.Compatibility
and set its value to WG3NT
. This should eliminate the extra characters that come in from the Rlogin client shipped with WG3NT.
Chatting with Blaz in WorldLink about this. Confirmed your latest fix works great!
Thank you so much!!1!1one
Module Information
Describe the bug Whenever a Rlogin connection is initiated from a Worldgroup 3.x BBS's Rlogin client, "ss(ANSI up arrow)Pdd" is sent into the emulated module as though the user typed it. This is a known issue with the WG3.x Rlogin client.
To Reproduce Steps to reproduce the behavior:
Expected behavior Would like to see MBBSEmu ignore these characters when a connection is initiated.
Screenshots
Software Information: