[WCCMMUD] MajorMud - Map of Newhaven has extra Carriage Returns

[tuday2]

Module Information

• Identifier: WCCMMUD
• Module Name: MajorMud
• Version: 1.11g

Describe the bug Map of Newhaven has extra Carriage Returns

To Reproduce Steps to reproduce the behavior:

1. Enter MajorMud module
2. Create character if none exists, enter game
3. Execute "MAP" command
4. See Error

Expected behavior Map displays correctly

Screenshots

No Console Error

Software Information:

• OS: Windows Server 2019 Standard
• Telnet Client: NetRunner
• MBBSEmu Build: 101820-1

[enusbaum]

The problem here is that the information is coming from a .ANS file, which already has properly formatted \r\n newline escapes.

When we outprf(), the helper method FormatNewLineCarriageReturn is called, which replaces any \r\ with \r\n and any \n with \r\n. I'm adding code to verify that the sequence being replaced isn't already \r\n (or reverse order) to ensure we don't DOUBLE the new lines.

[enusbaum]

[paladine]

The fix has broken TA's st\r\n output

TA outputs a \r\n when in actuality this should be expanded to \r\n\r\n. TA works when any \r or \n is expanded to \r\n, though obviously MMUD works differently

[paladine]

Maybe we want to continue the prior behavior during a prfmsg call but do not do the expansion in a normal prf write?