search

mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
132 stars 14 forks source link

[GALSNV] SuperNova - Endless loop after selecting your opponent -- new connections get hung #336

Closed tuday2 closed 3 years ago

tuday2 commented 3 years ago

Module Information

Describe the bug When playing a game, sometimes you enter an endless loop after selecting your opponent -- new connections get hung

To Reproduce Steps to reproduce the behavior:

  1. Add module to moduleConfig.json
  2. Load MBBSEmu
  3. Enter module
  4. (P) Play game
  5. Select "00" for computer, then type a single character and hit enter
  6. See error

Expected behavior Able to play game

Screenshots

2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8829 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper Converted a to A
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg Added 179 bytes to the buffer from message number 64
2020-12-20 19:21:43.8974 Info MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf Reset Output Buffer

Software Information:

enusbaum commented 3 years ago

When I'm running it, I get a missing Ordinal error. I'm wondering if the fixed printf formatting that was just merged to master fixed the loop and now we're getting a missing ordinal MAJORBBS.128 (CNCSIG)

enusbaum commented 3 years ago

image

enusbaum commented 3 years ago

@tuday2 Was this fixed with #338 ?

tuday2 commented 3 years ago

Closed by #338