search

mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
128 stars 14 forks source link

rLogin - MysticBBS - Extra Carriage Return #42

Closed tuday2 closed 3 years ago

tuday2 commented 3 years ago

When going from MysticBBS <> MBBSEmu on Windows 2019 Server Standard, using port 31337

I have tried Mutants!, MajorMud, and Casino -- all of them are adding an extra carriage return after every line

image

enusbaum commented 3 years ago

We moved the \r\n logic for strings to the ExportedModuleBase from the TelnetSession. The code still exists in the RloginSession handler. This needs to be removed.

https://github.com/enusbaum/MBBSEmu/blob/master/MBBSEmu/Session/Rlogin/RloginSession.cs#L72

Note: The whole RloginSession needs to be refactored to match the async pattern implemented in TelnetSession