mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
128 stars 14 forks source link

[WCCMMUD] Majormud - Needs further line wrapping improvements #526

Closed fletcherm closed 2 years ago

fletcherm commented 2 years ago

Module Information

Describe the bug

@paladine introduced some custom line wrapping code so that Majormud wouldn't print long strings all on one line.

It mostly works and Megamud is happy, but there is at least one place the wrapping isn't quite right.

I'll add screenshots to this as I find these places.

Expected behavior Line wrapping should match worldgroup's.

Screenshots

image

Mbbsemu on the left, wg3 on the right

Software Information:

paladine commented 2 years ago

There's some indication that the data files have line breaking information in them, see below

 N   e   w   h   a   v   e   n   ,       V   i   l   l   a   g
157414440   e       E   n   t   r   a   n   c   e  \0  \0       E   n   d
157414460  \0   E   n   d  \0  \0   l  \0   o   u   t   h       A   l   l
157414500   e   y  \0  \0  \0   W   e   l   c   o   m   e       t   o    
157414520   N   e   w   h   a   v   e   n   !       Y   o   u       a   r
157414540   e       s   t   a   n   d   i   n   g       a   t       t   h
157414560   e       c   r   u   d   e       w   o   o   d   e   n       g
157414600   a   t   e   s       o   f       t   h   e  \0   v   i   l   l
157414620   a   g   e       e   n   t   r   a   n   c   e   ,       i   n
157414640       t   h   e       m   i   d   d   l   e       o   f       a

There seems to be a null character where the line break should be. I wonder if this null is being passed to MBBSEmu or whether MMUD is supposed to be replacing \0 with \r\n itself?

enusbaum commented 2 years ago

@fletcherm This should now be fixed with #529 -- give it another test and let us know!

fletcherm commented 2 years ago

Yep, ran through this last night and today. Looks good now. Thanks.