mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
128 stars 14 forks source link

[MUICHAOS] Swords of Chaos - Main Menu for game events not working #558

Closed enusbaum closed 8 months ago

enusbaum commented 2 years ago

Module Information

Describe the bug Since the refactor of btuoes, SoC has broken and no longer properly supports game input from the main menu. Looking at the debug (below), the input is utilizing btuoes which (from the documentation), I believe we are no longer handling properly.

I suspect because of this, the state and substate is wrong after btuoes is processed (as I do not believe we're currently calling injrou as part of the routine).

2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Galgsbl.btuoes Value 0 for Channel 0
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->status == RINGING
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->state == 10
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->substt == 23
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.setmbk (MUICHAOS) Enqueue Previous MCV File: MUICHAOS.MCV (Pointer: FFFF:0000)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.setmbk (MUICHAOS) Set Current MCV File: MUICHAOS.MCV (Pointer: FFFF:0000)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Galgsbl.btuoes Value 0 for Channel 0
2022-04-03 13:57:20.9897 Warn MBBSEmu.HostProcess.ExportedModules.Galgsbl.btutsw Set Screen Width for Channel 0 to 80
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Galgsbl.btuhcr Set hard-CR character 0D on Channel 0 (Ignored -- only for ASCII mode)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Galgsbl.btuscr Set soft-CR character 0A on Channel 0 (Ignored -- only for ASCII mode)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Galgsbl.btuchi Assigned Character Interceptor Routine 0002:62CA to Channel 0
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.toupper (MUICHAOS) Converted e to E
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_open (MUICHAOS) Opening File: c:\dos\muichaos\MUICHAOS\DATA\NAMEFILE.DAT
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_open (MUICHAOS) c:\dos\muichaos\MUICHAOS\DATA\NAMEFILE.DAT FILE struct written to 1001:FDC2
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_close (MUICHAOS) Closed File 1001:FDC2 c:\dos\muichaos\MUICHAOS\DATA\NAMEFILE.DAT (Stream: FFFF:0005)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_open (MUICHAOS) Opening File: c:\dos\muichaos\MUICHAOS\DATA\USERFILE.DAT
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_open (MUICHAOS) c:\dos\muichaos\MUICHAOS\DATA\USERFILE.DAT FILE struct written to 1001:FD86
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.fseek (MUICHAOS) Seek to 0 in 1001:FD86 (Stream: FFFF:0005)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.f_close (MUICHAOS) Closed File 1001:FD86 c:\dos\muichaos\MUICHAOS\DATA\USERFILE.DAT (Stream: FFFF:0005)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.today (MUICHAOS) Returned packed date: 21635
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.prf (MUICHAOS) Added 5 bytes to the buffer
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.prfmsg (MUICHAOS) Added 269 bytes to the buffer from message number 689
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.outprf (MUICHAOS) Sent 273 bytes to Channel 0
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.clrprf (MUICHAOS) Reset Output Buffer
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.rstmbk (MUICHAOS) Reset Current MCV to MUICHAOS.MCV (FFFF:0000) (Queue Depth: 0)
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->status == CR_TERMINATED_STRING_AVAILABLE
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->state == 10
2022-04-03 13:57:20.9897 Debug MBBSEmu.HostProcess.ExportedModules.Majorbbs.UpdateSession (MUICHAOS) 0->substt == 34

To Reproduce Steps to reproduce the behavior:

  1. Load the Module
  2. Input E to Enter the Game
  3. Observe it re-prints the main menu
enusbaum commented 8 months ago

Fixed with #595

Confirmed working in https://github.com/mbbsemu/MBBSEmu/tree/v1.0-alpha-111223

image