mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
126 stars 14 forks source link

Print warning messages before cleanup runs. #585

Closed fletcherm closed 9 months ago

fletcherm commented 10 months ago

Note: this code was written largely by ChatGPT 4, so it may look a little different than the surrounding code. It was, of course, still inspected by a human. :)

What appears to be working:

What appears to be missing:

Next steps:

fletcherm commented 10 months ago

@enusbaum @paladine This is a draft PR and not ready to merge. But I'd appreciate if you can take a look and at least see if you can identify when I'm only seeing the first warning message and not subsequent messages.

fletcherm commented 10 months ago

cleanup-warnings

Attached is a screenshot of what the cleanup warnings look like on WG.

fletcherm commented 9 months ago

@enusbaum @paladine Alright, would love if you guys can take another look at this.

Only significant change since last round of reviews is that I changed how the cleanup time and grace period work, as we discussed in discord. (grace period comes after cleanup time, for whatever reason) This should better match WG.

My bigger ask is that someone test & confirm the behavior that cleanup and the cleanup warning run more than once, and not just after the initial setup. Normally that would be once a day, of course, but feel free to tweak values to make it happen more frequently.

I did do some experiments to test this myself, and things look good... but I had to hack enough lines of code to make cleanup more frequent that I kinda worry I changed something else incidentally and tainted the experiment. That is why I'd really appreciate another person testing it as well.