search

mbbsemu / MBBSEmu

The MajorBBS Emulation Project is an Open Source, Cross-Platform emulator for easily running The MajorBBS & Worldgroup Modules
https://www.mbbsemu.com
MIT License
126 stars 14 forks source link

Logging & Exception Fixes #624

Closed enusbaum closed 3 weeks ago

enusbaum commented 3 weeks ago

Two small fixes around exception handling.

  1. CATASTRO errors were being written to console, not the logger. This means they weren't included in the GUI logs and were lost.
  2. When a module errors out and needs to be disabled, users within the module are supposed to be showed a graceful message. This assumes the users are "IN" a module when a crash happens, but when running Login/Logout routines, the user technically isn't "IN" the module to where they are displayed a message. The result was that MBBSEmu would crash and not disable the module.

This fix allows the module to still be disabled, and since the users are in non-interactive routines, no need to "Gracefully" exit them, they'll exit anyway.