search

mbdavid / LiteDB.Studio

A GUI tool for viewing and editing documents for LiteDB v5
MIT License
781 stars 200 forks source link

Editing always fails #46

Open augomat opened 3 years ago

augomat commented 3 years ago

Compiled last version (1cda397), editing of attached db always gives me "Current document not found"

image

image

Something seems to be odd with the cell-tags, not sure how this is supposed to work with the bindings but tags are always null.

image

markusstephany commented 3 years ago

It seems that the UIExtensions class broke the grid as cell tags are not set anymore to document data. Also the overall handling has changed so I think the GrdResult_CellBeginEdit in MainForm does not work anymore. I tried to fix those issues (and it seems to work...) in my fork but as I faced that issue after quite a few other modifications, my fork does also contain other changes (e.g. overall refactoring, settings dialog), so it will take some time to find just those changes related to this bug...

BR Markus

augomat commented 3 years ago

Thanks al lot, will try it out! It's a pity that much of the improvements/fixes appear to happen in forks which are never merged back. However, as you pointed out, the diff of yours is huge, mainly due to code formatting as far as I have seen. That's unfortunate.

markusstephany commented 3 years ago

Yes, most of the changes are cosmetics (personal ReSharper code style applied). Except for the settings dialog, removal of ILMerge and the fix for the editing issues. Maybe someone can back-port the latter mods to the original code base...

Paul-Williams commented 9 months ago

Latest version of this fork does not solve the problem.

Steps to reproduce:

  1. Open DB
  2. Run 'collection select all' query (SELECT $ FROM MyTable)
  3. Edit text 'field' in query results (NB: Editing automatically clears value from cell in grid - another bug?)
  4. Navidate away from edited row
  5. Error: Current document was not found. Try run your query again,

Bug makes grid editing of document imposible. Bug should be fixed, or grid made read-only.