search

mbdavid / LiteDB

LiteDB - A .NET NoSQL Document Store in a single data file
http://www.litedb.org
MIT License
8.36k stars 1.22k forks source link

Fix security issue for V4 #2424

Closed viveleltsi closed 1 week ago

viveleltsi commented 4 months ago

Fix the severity issue for the old v4 liteDB version. The goal is to have a patch for application who cannot update to V5.

Because this is my first PR for this project I think my changes should be properly checked and validated.

fix #2418

PS: This branch should not be merged on master but probably stay on a fix branch.

mbdavid commented 4 months ago

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

viveleltsi commented 4 months ago

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

Hello ! Thank you for your response. My branch was created on the v4.1.4 tag. (commit 918b6500b16bcb85a1d2e713c5486bd6491f9016). Would you like me to try rebasing it on the v4 branch ? (Sorry I didn't saw this branch :S )

viveleltsi commented 4 months ago

I rebase my branch onto the V4 branch (commit 46a83879e31a66e02a46d84ec695e537434dbdef) and I rebuild it and run the unit testing. It's all good.

mbdavid commented 4 months ago

Nice! Thanks.... Could you create a pull request for v4 branch? Than I will create a new tag for this new release

viveleltsi commented 4 months ago

Yes of course. I updated this PR to target the v4 branch.

viveleltsi commented 3 months ago

@mbdavid I updated the PR to the v4 branch :)