search

mbdavid / LiteDB

LiteDB - A .NET NoSQL Document Store in a single data file
http://www.litedb.org
MIT License
8.35k stars 1.22k forks source link

Add failing tests #2497

Closed JKamsker closed 4 days ago

JKamsker commented 3 weeks ago

That way people could submit prs only containing tests that should work but currently don't

pictos commented 3 weeks ago

But why? I would say that's better to contributors implementing the test with the actual fix... I believe that kind of test will pollute the test suite

JKamsker commented 3 weeks ago

This would be a benchmark to measure the (hopefully increasing) stability of the library. That way we know what the user would expect and we or someone else can fix it if they got the resources for it.

pictos commented 3 weeks ago

This would be a benchmark to measure the (hopefully increasing) stability of the library.

can you expand more on this?

That way we know what the user would expect and we or someone else can fix it if they got the resources for it.

on GitHub we already have issues to mark what needs to be worked, and the community interaction on those issues will point us to the highest priority ones. So how having a bunch of failing tests would be a better measurement system than what GitHub already provide to us?

pictos commented 2 weeks ago

can we close this one?