search

mbdavid / LiteDB

LiteDB - A .NET NoSQL Document Store in a single data file
http://www.litedb.org
MIT License
8.35k stars 1.22k forks source link

Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 #2499

Closed jdtkw closed 2 weeks ago

jdtkw commented 3 weeks ago

Fixes #2494

Avoid using AesStream class when opening an older version of LiteDB database, as its imcompatible with the older versions.

JKamsker commented 3 weeks ago

Can you add tests that show that the upgrade works with your changes?

JKamsker commented 3 weeks ago

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

jdtkw commented 2 weeks ago

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

Yeah, I went for a fix for the problem that would limit any form of adverse interaction with other code / use cases. Not 100% happy with it myself, but feel it's not going to affect normal operation once it has upgraded to to the latest format.

jdtkw commented 2 weeks ago

Can you add tests that show that the upgrade works with your changes?

Thanks for doing this.

jdtkw commented 2 weeks ago

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

Hi @pictos - think @JKamsker already responded to the breaking change issue. I've fixed the tabs vs. spaces problem. Please let me know what else needs fixing.

Do we have a timeline on when this could be rolled into a release?

pictos commented 2 weeks ago

@jdtkw we will see other PRs to merge and then schedule a SR version, that should not take so long.

Thanks for your contribution