search

mbecker20 / komodo

🦎 a tool to build and deploy software on many servers 🦎
GNU General Public License v3.0
1.21k stars 20 forks source link

Docker login before compose pull #40

Closed febalist closed 4 weeks ago

febalist commented 4 weeks ago

During the deploy stack process, I encounter an “access forbidden” error at the compose pull stage: CleanShot 2024-08-20 at 09 51 34@2x

It looks like docker login isn’t happening before compose pull, even though config.registry_account is set up.

In the code, I noticed that in /bin/periphery/src/compose.rs, docker login happens after compose pull. It might need to be swapped to ensure login happens first.

Core 1.13.3 Periphery 1.13.3

mbecker20 commented 4 weeks ago

You are correct, thanks for the Report! Fixed in this commit: https://github.com/mbecker20/monitor/commit/a2758ce6f4c557b52ec8acb49e929648c4d48c91

I'm building 1.13.4 now to address this issue, will release shortly. Thanks for your interest in the project!

mbecker20 commented 4 weeks ago

Hey, the lastest release is out and should fix the issue.

https://github.com/mbecker20/monitor/releases/tag/v1.13.4

febalist commented 4 weeks ago

Thank you for the quick fix! The project looks incredibly useful and convenient.