mbecker20 / komodo

🦎 a tool to build and deploy software on many servers 🦎
GNU General Public License v3.0
1.21k stars 20 forks source link

[Feature] Make resource deletion clean up optional #50

Open mbecker20 opened 2 weeks ago

mbecker20 commented 2 weeks ago

Currently, when a Resource like Stack or Deployment is deleted, the underlying docker target (container / compose project) will be cleaned up, ie "docker compose down".

The intention is to help keep your servers clean. When you delete a resource you won't see the status anymore, so if the container wasn't cleaned up it would keep running but not be observable. A user could forget about it after deleting the resource, and unknown to them there is a container still running that used to be part of a Deployment / Stack. This can obviously cause some problems.

On the other hand, users may just want to "release" a container / stack, in this case they may want to delete the resource but not the underlying Container / Compose project.

To satisfy both cases, the "Confirm Delete" menu that prompts before deletion can include a checkbox for "Clean up containers / networks". It will be default checked, but users can just uncheck that box if they wish. And it also gives more visibility to the fact that it will delete containers when you delete a Stack.

🦎