Closed timIdeaTech closed 1 week ago
Not sure I follow the 2 failed checks above. I emulated the other enum comments for style and I'm not sure what the other is...
If I can fix it, let me know. If not, let me know how I can avoid this in the future.
I'm assuming I'm not on the hook for the mbed-ce html doc changes, correct?
For the style check it appears to be complaining about the space after the asterisk. Dang astyle it can be so finicky sometimes...
As for the other error, it would appear that on this line, #SPI
needs to be changed to #mbed::SPI
. I think that Doxygen was linking it to this enum instead of the SPI class!
Sorry, just figuring this all out. Should be good to merge the 3 files except doxygen-awesome-css. Not sure how to back out that one.
Summary of changes
OSPIFBlockDevice.h defined "SPI" as a global enum under the name _mode.
Both are collision/ambiguity hazards so, using the global enum convention of the existing driver code
has been changed to:
as well as any references in OSPIFBlockDevice.cpp
Impact of changes
Any reference to the previous enum's in user code will result in preprocessor not defined errors.
Migration actions required
All references to the previous enum's in user code will have to be updated with the new prefix OSPIF_OPIMODE
Documentation
Update references in change_mode() references in https://mbed-ce.github.io/mbed-os/class_o_s_p_i_f_block_device.html)
Pull request type
Test results
Reviewers
@multiplemonomials