search

mbeddr / mbeddr.core

The mbeddr core. An extensible C
Eclipse Public License 2.0
225 stars 77 forks source link

MarginComment overlaps editor content #1526

Open hnehls opened 8 years ago

hnehls commented 8 years ago

When the editor content exceeds the 'virtual' page size, an added MarginComment overlaps the editor content: overlapping margin comment

slisson commented 8 years ago

Not able able to reproduce it.

hnehls commented 8 years ago

How can I support? We are using MPS 3.3.5 and mbeddr nighlty_127. The 'overlapped editor content' is of type de.slisson.mps.tables filled with Expressions and the MarginComment is added to a table cell's content. It is also visible when just displaying a very long name (INamedConcept.name). Maybe it is depending on MPS version (was also present with 3.3.4) and is already solved with a later version but I could not check, yet.

OK, found a solution: It depends on the 'Text Width' property of the Editor. Doubled from 120 (seems to be the default) to 240 and the specific problem is solved.

Maybe there could be a more common solution to e.g. move the comment to the most righter position. On the other hand the strict position at virtual page size has also an advantage...

bkolb commented 8 years ago

Can you please provide an example so that we can debug it?

slisson commented 8 years ago

I can reproduce it now. I didn't see the table.