mbeddr / mbeddr.core

The mbeddr core. An extensible C
Eclipse Public License 2.0
224 stars 77 forks source link

Integrate changes needed for SECURE #2402

Closed AlexeiQ closed 2 months ago

AlexeiQ commented 3 months ago

This PR integrates necessary changes for itemis SECURE which were implemented on #2221 and therefore by #2198 by others. I've cherrypicked and updated the necessary commits and ommited all unnecessary/ now irrelevant changes after reviewing all the commits.

❗ The only change where I'm unsure and would like some advice/ additional review is: com.mbeddr.mpsutil.actionsfilter.runtime: Set the solution kind to NONE. (eee1745d)

Changes

com.mbeddr.mpsutil.editingGuide

mpsutil.hyperlink.runtime

com.mbeddr.mpsutil.asynccell

com.mbeddr.mpsutil.actionsfilter.runtime

com.mbeddr.core.base + .../pluginSolution

com.mbeddr.mpsutil.actionsfilter

Checklist for creating a good PR (can be deleted)

AlexeiQ commented 2 months ago

Thanks for the review and feedback :)

I assume you tested this change.

No, I did test everything else but the actionsfilter yet. I executed the gradle-command "behind" ./gradlew install, but it didn't rebuilt the module, which is then copied to the MPS plugins directory. I have to do this tomorrow again properly.

AlexeiQ commented 2 months ago

I did test the actionsfilter plugin by now, by calling ./gradlew install and thus installing a new actionsfilter plugin into my MPS (cleaning the build and the plugin-directory beforehand). The actionsfilter is still working properly afai can see and the idea.log is free of any new, releated exceptions. After a discussion with @alexanderpann we agreed to go on with the merge.