Closed AlexeiQ closed 2 months ago
Thanks for the review and feedback :)
I assume you tested this change.
No, I did test everything else but the actionsfilter yet. I executed the gradle-command "behind" ./gradlew install
, but it didn't rebuilt the module, which is then copied to the MPS plugins directory. I have to do this tomorrow again properly.
I did test the actionsfilter plugin by now, by calling ./gradlew install
and thus installing a new actionsfilter plugin into my MPS (cleaning the build and the plugin-directory beforehand). The actionsfilter is still working properly afai can see and the idea.log
is free of any new, releated exceptions. After a discussion with @alexanderpann we agreed to go on
with the merge.
This PR integrates necessary changes for itemis SECURE which were implemented on #2221 and therefore by #2198 by others. I've cherrypicked and updated the necessary commits and ommited all unnecessary/ now irrelevant changes after reviewing all the commits.
❗ The only change where I'm unsure and would like some advice/ additional review is:
com.mbeddr.mpsutil.actionsfilter.runtime
: Set the solution kind toNONE
. (eee1745d
)Changes
Force Save All
andExecute Re-Runnable Migrations
oncom.mbeddr.core
andcom.mbeddr.mpsutil
com.mbeddr.mpsutil.editingGuide
ProgramFragments
support error suppression, i.e. all model-checking errors are suppressed inProgramFragments
, so modelchecker will disregard them and not clutter.mpsutil.hyperlink.runtime
HyperlinkUtil.openInBrowser()
behaves like no-op instead of raising an exception on null/empty URLs.com.mbeddr.mpsutil.asynccell
com.mbeddr.mpsutil.actionsfilter.runtime
NONE
. The actual reason for this change is not documented unfortunatly. It was probably either a simple clean-up or it caused class-loading issues in a project and therefore was necessary, which at the current time cannot be reproduced/verified anymore.com.mbeddr.core.base + .../pluginSolution
IMbeddrIDERoot
in mbeddr menus.com.mbeddr.mpsutil.actionsfilter
Checklist for creating a good PR (can be deleted)