search

mbeddr / mps-build-backends

Command-line utilities used e.g. by Gradle plugins to generate or check models.
Apache License 2.0
3 stars 4 forks source link

modelcheck: Update jackson-dateformat-xml from 2.11.+ to 2.16.+ #15

Closed alexanderpann closed 10 months ago

alexanderpann commented 10 months ago

A customer is using Jackson dependencies (core, annotations, databinding, datatype-pcollections, datatype-jsr310) in version 2.15.3. With the change to 2.16.1 the model checker apparently can't create the result XML file (no such method exception).

By the way, why on earth does the build take 1 hour?

sergej-koscejev commented 10 months ago

The build takes one hour because it's testing each backend against several MPS versions. This could be parallelized, I guess.

alexanderpann commented 9 months ago

@sergej-koscejev Thanks for reverting the change in https://github.com/mbeddr/mps-build-backends/commit/a364c7581b239fd24089701d338695ee8ad43b54. I think I figured out the problem and why the tests didn't catch the resulting exception: java.lang.NoSuchMethodError: 'void com.fasterxml.jackson.core.base.GeneratorBase.<init>(int, com.fasterxml.jackson.core.ObjectCodec, com.fasterxml.jackson.core.io.IOContext)':

The tests only depend on some MPS libraries but not the full IntelliJ platform. When you execute the modelchecker from the mps-gradle-plugin a full MPS environment is started. The IntelliJ platform contains the jackson-databind library in version 2.13.1 for MPS 2022.2 and older versions which probably collide with the version of the model checker plugin: https://github.com/JetBrains/intellij-community/blob/222.4554/.idea/libraries/jackson_databind.xml

sergej-koscejev commented 9 months ago

The tests only depend on some MPS libraries but not the full IntelliJ platform.

@alexanderpann But integration-tests launch the whole platform, don't they?