Broken symlink created during bundling

mbeddr / mps-gradle-plugin

Miscellaneous tasks that were found useful when building MPS-based projects with Gradle.

Other

14 stars 15 forks source link

Open arimer opened 6 years ago

arimer commented 6 years ago

When creating a .dmg file containing the application a broken symlink is still created under

Application/MyAppapp/Contents/bin/*.dylib

To verify this for your application you could just use the following command to find the broken link:

find . -type l ! -exec test -e {} \; -print

It looks like the following code is always executed. I will add a condition there.

arimer commented 6 years ago

Just saw that we have duplicated and outdated code in two scripts:

and

I am not sure if we want to keep both of it, because it seems to be only relevant for older MPS versions.

sergej-koscejev commented 6 years ago

@arimer you probably meant one of the files to be mpssign.sh in your comment.

We should call bundle_macos_jdk.sh from mpssign.sh, and remove most of the code from mpssign.sh except for the argument parsing and signing.

mpssign.sh should:

Parse arguments (also check the SIGN_ arguments before the script does anything)
Call bundle_macos_jdk.sh with appropriate args (if no JDK was given, pass empty string as JDK)
Do the signing stuff (code beginning with echo "Signing application $BUILD_NAME", up to echo "check sign done").

arimer commented 6 years ago

Could we maybe agree to merge first the simple change introduced here: https://github.com/mbeddr/mps-gradle-plugin/pull/27

And afterwards refactor the buildscripts?

sergej-koscejev commented 6 years ago

@arimer sure :)