search

mbeddr / mps-gradle-plugin

Miscellaneous tasks that were found useful when building MPS-based projects with Gradle.
Other
14 stars 15 forks source link

Rework DSStore from perl to a Gradle task #71

Open vlsi opened 4 years ago

vlsi commented 4 years ago

The current code is somewhat hard to follow, and it is not clear why arch -32 is needed:

https://github.com/mbeddr/mps-gradle-plugin/blob/24e832c4d4acc272b70663c9b64c87cc1c12cb5e/src/main/resources/de/itemis/mps/gradle/mpsdmg.sh#L56

What if DS_Store generation was written in Java-based code? For instance: https://formats.kaitai.io/ds_store/java.html

vlsi commented 4 years ago

I see IntelliJ IDEA does not use arch -32: https://github.com/JetBrains/intellij-community/blob/c838dd4efbd00629f2a5874f336a324a04a8c141/platform/build-scripts/tools/mac/scripts/makedmg.sh#L81

@sergej-koscejev, do you by chance remember why arch -32 is used for perl5.18 mpsdmg.pl execution in mps-gradle-plugin?

vlsi commented 4 years ago

An alternative approach migh be to reuse IDEA's build scripts.

For instance, they are still improved: https://github.com/JetBrains/intellij-community/commit/c838dd4efbd00629f2a5874f336a324a04a8c141

sergej-koscejev commented 4 years ago

Re arch -32: I copied the scripts over from mbeddr.core, I have no idea why it was used there. Here's relevant Git Blame for mbeddr.core: https://github.com/mbeddr/mbeddr.core/blame/a44cf0012dd573a403a5c340d65e02cebda2441d/buildUtil/mpsdmg.sh#L45

sergej-koscejev commented 4 years ago

@vlsi is there a particular feature that's missing or not working? What motivated you to focus on this code?

vlsi commented 4 years ago

@sergej-koscejev , AFAIK one of the issues is the current Perl script fails at GitHub Actions in macOS (e.g. https://github.com/mbeddr/mps-gradle-plugin/pull/70/checks?check_run_id=902243688 )