search

mbegan / Okta-Identity-Cloud-for-Splunk

Public REPO for splunkbase app
https://splunkbase.splunk.com/app/3682/
Other
19 stars 13 forks source link

fix proxy logic #12

Closed mbegan closed 5 years ago

mbegan commented 6 years ago

https://github.com/mbegan/Okta-Identity-Cloud-for-Splunk/blob/4011976f8c69e1ba9d0435eb1d9d70a22f1e75f3/bin/input_module_okta_identity_cloud.py#L312

This method doesn't work as expected, always returns true.

ditch the function and setup a hidden config item that defaults to disabling proxy server.

mbegan commented 5 years ago

the function or property used to determine if the instance is a cloud instance or not doesn't actually work.

I skirted around this issue by disabling proxy functionality by default and introducing a hidden parameter to enable proxy functionality.

To allow the proxy configuration exposed in the UI to function you need to add the allow_proxy = 1 param to the [additional_parameters] stanza in the local /ta_okta_identity_cloud_for_splunk_settings.conf

[additional_parameters]
allow_proxy = 1

Adding these and restarting will cause the code path that evaluates the configured proxy settings to run.