search

mbehr1 / adlt

Library and tools to handle automotive DLT (diagnostic log- and trace-) files in Rust.
7 stars 3 forks source link

fix(remote): queries that have been chunked returned wrong len #136

Closed mbehr1 closed 7 months ago

mbehr1 commented 7 months ago

If the queries had been chunked for parallel search within 64k msgs and then found less than wanted after the full search a wrong all_msgs_last_processed_len was returned. The hotfix from 0.55.2 avoided a panic but yielded wrong results then if later one the search window was extended.

Fixed the root cause and adjusted the part chunk size to 64 msgs only so that the existing unit tests find that bug as well.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.45%. Comparing base (73c0512) to head (0182c11).

Files Patch % Lines
src/bin/adlt/remote.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ======================================= Coverage 82.45% 82.45% ======================================= Files 31 31 Lines 12487 12487 ======================================= Hits 10296 10296 Misses 2191 2191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.