search

mbeijen / File-MimeInfo

Perl module for determining file types using the freedesktop.org shared mime-info database
https://metacpan.org/module/File::MimeInfo
20 stars 14 forks source link

Adjust Makefile.PL to use PREREQ_PM #41

Closed atoomic closed 4 years ago

atoomic commented 4 years ago

The dependencies list was using BUILD_REQUIRES which list modules used to build the distribution

To list dependencies required at run time you should use PREREQ_PM.

mbeijen commented 4 years ago

It's been a while so I forgot, but this uses travis-ci.org instead of travis-ci.com.

Your statement 'you should use PREREQ_PM' is not really true, you should use PREREQ_PM if you don't care about old perls. This would probably apply to your darkpan code, but for apps on cpan it's a different story.

As you can see, your PR will fail on older Perls than 5.14: https://travis-ci.org/github/mbeijen/File-MimeInfo/builds/729068052 and this is actually because of the ExtUtils::MakeMaker version. For this module, I'd still like to keep support for 5.12 and 5.10, I see no compelling reason to break this because it's nicer to use PREREQ_PM or so.

In DBD::mysql there is this messy code which checks if you have a new version of EUMM and otherwise merges the options... check this: https://metacpan.org/source/DVEEDEN/DBD-mysql-4.050/Makefile.PL#L906-910

If you want to make a PR like that, I'll consider it, but honestly, if you'd ask me it's not really worth it.