mbenabda / helm-local-chart-version

Bump Helm Chart version on local filesystem (inspired by https://github.com/shaneramey/helm-local-bump)
The Unlicense
23 stars 13 forks source link

Will not build currently with Go 1.10. #3

Closed derekbassett closed 6 years ago

derekbassett commented 6 years ago

Tried to install this component using both the install instructions and the manual build using Go 1.10 and is not able to build. Get the following error message:

glide install --strip-vendor
[INFO]  Downloading dependencies. Please wait...
[INFO]  --> Found desired version locally github.com/BurntSushi/toml b26d9c308763d68093482582cea63d69be07a0f0!
[INFO]  --> Found desired version locally github.com/ghodss/yaml 0ca9ea5df5451ffdf184b4428c902747c2c11cd7!
[INFO]  --> Found desired version locally github.com/gobwas/glob 5ccd90ef52e1e632236f7326478d4faa74f99438!
[INFO]  --> Found desired version locally github.com/golang/protobuf 4bd1920723d7b7c925de087aa32e2187708897f7!
[INFO]  --> Found desired version locally github.com/inconshreveable/mousetrap 76626ae9c91c4f2a10f34cad8ce83ea42c93bb75!
[INFO]  --> Found desired version locally github.com/Masterminds/semver 517734cc7d6470c0d07130e40fd40bdeb9bcd3fd!
[INFO]  --> Found desired version locally github.com/spf13/cobra 7b2c5ac9fc04fc5efafb60700713d4fa609b777b!
[INFO]  --> Found desired version locally github.com/spf13/pflag ee5fd03fd6acfd43e44aea0b4135958546ed8e73!
[INFO]  --> Found desired version locally gopkg.in/yaml.v2 d670f9405373e636a5a2765eea47fac0c9bc91a4!
[INFO]  --> Found desired version locally k8s.io/apimachinery cced8e64b6ca92a8b6afcbfea3353ca016694a45!
[INFO]  --> Found desired version locally k8s.io/helm 6af75a8fd72e2aa18a2b278cfe5c7a1c5feca7f2!
[INFO]  Setting references.
[INFO]  --> Setting version for github.com/spf13/pflag to ee5fd03fd6acfd43e44aea0b4135958546ed8e73.
[INFO]  --> Setting version for github.com/golang/protobuf to 4bd1920723d7b7c925de087aa32e2187708897f7.
[INFO]  --> Setting version for github.com/gobwas/glob to 5ccd90ef52e1e632236f7326478d4faa74f99438.
[INFO]  --> Setting version for github.com/ghodss/yaml to 0ca9ea5df5451ffdf184b4428c902747c2c11cd7.
[INFO]  --> Setting version for github.com/Masterminds/semver to 517734cc7d6470c0d07130e40fd40bdeb9bcd3fd.
[INFO]  --> Setting version for github.com/inconshreveable/mousetrap to 76626ae9c91c4f2a10f34cad8ce83ea42c93bb75.
[INFO]  --> Setting version for github.com/BurntSushi/toml to b26d9c308763d68093482582cea63d69be07a0f0.
[INFO]  --> Setting version for github.com/spf13/cobra to 7b2c5ac9fc04fc5efafb60700713d4fa609b777b.
[INFO]  --> Setting version for k8s.io/helm to 6af75a8fd72e2aa18a2b278cfe5c7a1c5feca7f2.
[INFO]  --> Setting version for k8s.io/apimachinery to cced8e64b6ca92a8b6afcbfea3353ca016694a45.
[INFO]  --> Setting version for gopkg.in/yaml.v2 to d670f9405373e636a5a2765eea47fac0c9bc91a4.
[INFO]  Exporting resolved dependencies...
[INFO]  --> Exporting github.com/BurntSushi/toml
[INFO]  --> Exporting github.com/ghodss/yaml
[INFO]  --> Exporting github.com/inconshreveable/mousetrap
[INFO]  --> Exporting github.com/golang/protobuf
[INFO]  --> Exporting github.com/spf13/cobra
[INFO]  --> Exporting github.com/Masterminds/semver
[INFO]  --> Exporting github.com/gobwas/glob
[INFO]  --> Exporting github.com/spf13/pflag
[INFO]  --> Exporting k8s.io/apimachinery
[INFO]  --> Exporting k8s.io/helm
[INFO]  --> Exporting gopkg.in/yaml.v2
[INFO]  Replacing existing vendor dependencies
[INFO]  Removing nested vendor and Godeps/_workspace directories...
[INFO]  Removing: /Users/dbasse202/go/src/github.com/mbenabda/helm-local-chart-version/vendor/k8s.io/apimachinery/vendor
go test github.com/mbenabda/helm-local-chart-version github.com/mbenabda/helm-local-chart-version/pkg/chartfile github.com/mbenabda/helm-local-chart-version/pkg/version
vendor/github.com/spf13/cobra/doc/man_docs.go:26:2: cannot find package "github.com/cpuguy83/go-md2man/md2man" in any of:
    /Users/dbasse202/go/src/github.com/mbenabda/helm-local-chart-version/vendor/github.com/cpuguy83/go-md2man/md2man (vendor tree)
    /usr/local/Cellar/go/1.10/libexec/src/github.com/cpuguy83/go-md2man/md2man (from $GOROOT)
    /Users/dbasse202/go/src/github.com/cpuguy83/go-md2man/md2man (from $GOPATH)

The problem appears to be that spf13/cobra introduced a dependency on github.com/cpuguy83/go-md2man

Something about running go test causes the file to be compiled and required, where as a go build does not.

mbenabda commented 6 years ago

Hi there, thank you for fixing this in https://github.com/mbenabda/helm-local-chart-version/pull/4