mbenkmann / limux-gosa

GOsa² is a web based adminstration tool for user accounts, groups, servers, clients, and many other things.
18 stars 5 forks source link

When forwarding a job, make sure faistate is settled before forwarding #140

Closed mbenkmann closed 9 years ago

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 19, 2013 14:25:33

Error scenario:

trigger_action_update for client C sent to server S1 client C is registered at server S2, so server S1 forwards the job Forwarding includes the following actions:

As part of deleting the old job for S1 the server S1 will set the faistate of C to "localboot". This cause a race condition. If server S2 begins executing the job before S1 has changed the faistate, then S2 will set the faistate to "softupdate" and S1 will reset it to "localboot".

Original issue: http://code.google.com/p/go-susi/issues/detail?id=140

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 20, 2013 04:17:36

Done in 258a156fbf61

The implementation is different than described in the ticket. It's not easily possible to make sure the faistate is settled, so instead we do not touch the faistate at all when removing a forwarded job.

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 20, 2013 04:17:45

Status: Done