mbenkmann / limux-gosa

GOsa² is a web based adminstration tool for user accounts, groups, servers, clients, and many other things.
18 stars 5 forks source link

When a peer comes up again, send new_server before full sync. Add a 30s wait. #141

Closed mbenkmann closed 9 years ago

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 20, 2013 12:16:09

It is possible that when a peer goes down and comes up again it has lost its keys. Because of this, a new_server needs to be sent before doing a full sync (the full sync will probably happen as side effect of the confirm_new_server, but check this).

A wait time of 30s should be added before resuming the connection to avoid exhausting CPU and/or memory in a situation where the 2 servers bombard each other with messages they don't understand (e.g. if the ServerPackages key has changed in the meantime which will make communication impossible). After a certain amount of connection losses per time unit, the server should probably be removed.

Original issue: http://code.google.com/p/go-susi/issues/detail?id=141

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 22, 2013 02:55:13

This issue probably overlaps with issue #81 .

mbenkmann commented 9 years ago

From mux2...@gmail.com on August 30, 2013 01:55:25

Done in f9f2998b3b3e without the 30s wait and without removing the server after too many failures per time unit. These changes will be reconsidered if the need arises.

Status: Done