search

mbenkmann / limux-gosa

GOsa² is a web based adminstration tool for user accounts, groups, servers, clients, and many other things.
18 stars 5 forks source link

Do not groom job DB with error result from LDAP #170

Closed mbenkmann closed 9 years ago

mbenkmann commented 9 years ago

From matthias...@gmail.com on April 17, 2014 10:35:11

Currently db/jobdb.go:groomJobDB() contains the following code:

system, err := SystemGetAllDataForMAC(macaddress, false)
if err == nil { faistate = system.Text("faistate") } else { faistate = err.Error() }

This means that if an SystemGetAllDataForMAC() returns an error (e.g. can't contact ldap server) the error message will be used as faistate. The result is that jobs will be removed as inconsistent.

Instead, the error should be logged and the grooming should be aborted.

Original issue: http://code.google.com/p/go-susi/issues/detail?id=170

mbenkmann commented 9 years ago

From mux2...@gmail.com on November 04, 2014 02:26:43

Done in git bbf322dc7ef4ff9168175b8e3dcebea515442135

Status: Done