search

mbentley / docker-omada-controller

Docker image to run TP-Link Omada Controller
739 stars 110 forks source link

SSL certificate names #60

Closed ulug79 closed 4 years ago

ulug79 commented 4 years ago

Please add environment variables for customizing certificate names

mbentley commented 4 years ago

Just curious, what's the use case where the certificate names are an issue?

ulug79 commented 4 years ago

I am using traefik 2.2 with letsencrypt certificate wildcard generation. A special container extracts the certificate in json format and puts them in a folder named cert.pem, fullchain.pem and key.pem

ulug79 commented 4 years ago

at home i am using Unifi Controller container from https://hub.docker.com/r/jacobalberty/unifi

and in it you can set non-standard names through environment variables

mbentley commented 4 years ago

Are you expecting to just be able to update the certificate name or the whole path? I am assuming just the file name based on the Unifi example.

ulug79 commented 4 years ago

For example in Unifi Controller i mount certficate folder as volume in container, In enviroment variable I just indicate the different name. Please create 2 environent variable for full chain name and key name. Thanks.

For example: If your certificate or private key have different names, you can set the environment variables CERTNAME and CERT_PRIVATE_NAME to the name of your certificate/private key, e.g. CERTNAME=my-cert.pem and CERT_PRIVATE_NAME=my-privkey.pem.

mbentley commented 4 years ago

👍 Sounds good. #61 should resolve this and add the ability to have custom names.