search

mbentley / docker-timemachine

Docker image to run Samba (compatible Time Machine for macOS)
Apache License 2.0
527 stars 65 forks source link

Submit to DockSTARTer #118

Closed samAheenan closed 2 years ago

samAheenan commented 2 years ago

As per the feature request submitted at DockSTARter's GitHub, I think that this container would be a great addition to their suite. They accept Pull Requests for container submissions so I thought I would come straight to the source to request it.

Is your feature request related to a problem? Please describe. No problem - just a suggestion. I currently have a separate VM for Time Machine only and would love to see it be part of DockSTARter so I keep all my home lab stuff on the same Docker-specific VM.

Describe the solution you'd like Submitting this container to the DockSTARter project by using a Pull Request on their GitHub.

Additional context I am adequate at implementing solutions that other people have created but am sadly inadequate at creating those solutions myself which is why I am requesting it rather than just doing it myself! Ideally it would benefit people other than me as well though.

mbentley commented 2 years ago

Interesting - had never heard of DockSTARTer before. Not sure if I have the spare time at the moment to contribute to that and "support" it but funny enough, someone has contributed another one of my packaged images to it (omada-controller).

samAheenan commented 2 years ago

Thanks for your reply, Matt.

mbentley commented 2 years ago

No worries. If I get the time, I'll consider adding my time machine image if I get a chance to figure out the format; didn't look terrible, just figuring out exactly what is needed to convert the existing compose file into the required format.

samAheenan commented 2 years ago

Legend - thanks again! :-)

mbentley commented 2 years ago

I submitted https://github.com/GhostWriters/DockSTARTer/pull/1494 this morning.

mbentley commented 2 years ago

Looks like it is going to be added; closing.

samAheenan commented 2 years ago

I watched the progress on that ticket with excitement. Thanks again!