Update entrypoint.sh - Githubissues

mbentley / docker-timemachine

Docker image to run Samba (compatible Time Machine for macOS)

Apache License 2.0

527 stars 65 forks source link

Update entrypoint.sh #129

Closed luizvaz closed 1 year ago

luizvaz commented 1 year ago

Allow setting custom values to the smb.conf

server min protocol = ${CUSTOM_SMB_PROTO}NT1|SMB2
ntlm auth = ${CUSTOM_SMB_AUTH}

Where : CUSTOM_SMB_PROTO = NT1|SMB2|SMB3|... (Value List) CUSTOM_SMB_AUTH = no|yes

This solves issues for some clients trying to connect using an old protocol, and receiving messages like:

reply_negprot: No protocol supported !
ntlm_password_check: NTLMv1 passwords NOT PERMITTED

luizvaz commented 1 year ago

Thanks! Could you also add docs to the https://github.com/mbentley/docker-timemachine/blob/master/README.md#optional-variables-for-smb section to describe the feature?

Done!

luizvaz commented 1 year ago

Tested on an image pulled and working fine. Thanks!