search

mberlanda / cheidelacoriera

This Rails application aims to become a management system for away fans.
GNU General Public License v3.0
2 stars 1 forks source link

ci: update Github actions to report code coverage #203

Closed mberlanda closed 2 years ago

mberlanda commented 2 years ago
mberlanda commented 2 years ago

it looks like v 0.21 of SimpleCov is generating reports that cannot be parsed by the code climate utility:

Error: json: cannot unmarshal object into Go struct field resultSet.coverage of type []formatters.NullInt

(similar to the issue saw in https://github.com/DEFRA/defra-ruby-address/pull/9)

this may come from here: https://github.com/codeclimate/test-reporter/blob/2edadbde66218db020d4b7b1cc9d58825f15c749/formatters/simplecov/simplecov.go#L31-L45

mberlanda commented 2 years ago

with simplecov (0.21.2) ./coverage/.resultset.json starts with:

{
  "RSpec": {
    "coverage": {
      "/home/runner/work/cheidelacoriera/cheidelacoriera/spec/controllers/crud/users_controller_spec.rb": {
        "lines": [
          null,
          null,
          1,
          null,

However the test reporter expects a structure like: https://github.com/codeclimate/test-reporter/commit/d3d488b3d3a33b39fb93a5b7534852c6b72a3473