search

mbest / knockout-deferred-updates

Deferred Updates plugin for Knockout <=3.3.0
http://mbest.github.io/knockout-deferred-updates/
134 stars 23 forks source link

Knockout 3.4 #31

Open nmehlei opened 8 years ago

nmehlei commented 8 years ago

I know that 3.4 is not yet stable (though it seems like its release is only days away) but it looks like ko-deferred-updates has to be updated to support ko 3.4. I noticed errors when trying to use 3.4's rate limiting functionality.

I guess at some point in time, this plugin will be abandoned due to the efforts to integrate deferral into ko's core, but I hope that we're not there yet as this plugin seems to handle at least some use cases (like mine: https://github.com/knockout/knockout/pull/1905#issuecomment-149572622 ) better as of now ;)

mbest commented 8 years ago

If this would support 3.4.0, it would have to override the native deferred updates.

nmehlei commented 8 years ago

...which it seems to handle just fine, except one issue with rate limiting when native deferral is disabled.

But am I understanding you correctly that this plugin won't be updated to support 3.4?

mbest commented 8 years ago

I was certainly hoping that I wouldn't have to.

nmehlei commented 8 years ago

Understandable ... could you give me a few hints what might be different between the functionality of this deferred plugin and native deferral that could cause the endless recursion mentioned in the referenced issue?

mbest commented 8 years ago

Can you tell me more about your application and what steps you went through to produce the error?

nmehlei commented 8 years ago

Sorry for the long delay ... I managed to find the source of the endless recursion. I have to continue with my tests to be sure but it seems like it was only a single area of my code which resulted in this problem, which did not happen with the deferred plugin. But, I have to admit ... this area was not written well ;) I optimized it and all seems to be working fine.

mbest commented 8 years ago

I'm hoping to be able to provide some migration documentation for the upgrade to 3.4.0 from this plugin. Can you share what you had to do to make it work? If you like, you can email me directly (email is listed at the bottom of https://github.com/mbest/knockout-deferred-updates/).