mbest / knockout-deferred-updates

Deferred Updates plugin for Knockout <=3.3.0
http://mbest.github.io/knockout-deferred-updates/
134 stars 23 forks source link

Merge knockout-deferred-updates into master #6

Open mpj opened 11 years ago

mpj commented 11 years ago

Because it's awsum and the right thing to do.

mbest commented 11 years ago

Yeah. I think it will be eventually.

vamp commented 11 years ago

subscription slow down when ko.deferred enabled, comparison: http://jsperf.com/ko-computed-vs-subscription http://jsperf.com/ko-computed-vs-subscription-deferred

computed: 3x (cool!) but subscription: 0.5x

mbest commented 11 years ago

subscription slow down when ko.deferred enabled

That's interesting, I'll take a look when I have some time.

mbest commented 11 years ago

I've just made some updates to improve performance. The biggest functional change is that it now also eliminates duplicate updates for manual subscriptions.

mbest commented 11 years ago

Here's your test using the new version: http://jsperf.com/ko-computed-vs-subscription-deferred/2

vamp commented 11 years ago

Cool! Great work!

juuxstar commented 10 years ago

:+1: for merging to knockout officially. It's a must for any projects of a non-trivial scale. Any news on this?

I've forked Knockout for my own customizations but knockout-deferred overwrites some of the code in Knockout (mainly the computed) thus interfering with those changes. I'd rather not have to fork knockout-deferred as well.

mbest commented 10 years ago

I'll need to update this to support Knockout 3.2

mbest commented 10 years ago

@juuxstar. I understand your point about changing both. I'm hoping this will join Knockout whenever we do 4.0.