Open pgleeson opened 7 years ago
@pgleeson I have no clue what's happening... The NeuroML2 ones are still passing with the same .mep file and we didn't touch the .mod files... (or anything in those models)
Might be the same as issue #13 They're also failing for me locally with version 7.4 1370 (same as on travis). Just asked the NEURON developers about it: https://www.neuron.yale.edu/phpBB/viewtopic.php?f=6&t=3747
-> Update on this: NEURON version 7.5 didn't solve the issue (but crashed the .mod file generated from Capool.nml) so we stick to 7.4
To be honest we skipped checking through the changes since our first clone from bitbucket and that's why some travis tests were failing...
CCK+BC was failing since big changes were made in Marianne's last bitbucket commit. The conductances are now set to the values reported in eLife paper as in bitbucket version f1bb857, however 2 channels: Navcck and KCaS needed to be as they were in version f1bb857, since the ones in version 0e789a2 and also reported in the paper don't lead to the behaviour shown in http://mariannebezaire.com/ca1_graphic/celltype.html#cckcell and in the paper -> this 2 channel descriptions are inconsistent with the results in the eLife paper I've created new versions of the channels and the reoptimized cells and both versions are passing now
Cutsuridis cell (as a simpler PC template) is not even mentioned in the paper so I couldn't check which version is the correct... I've just setted it back to bitbucket version f1bb857 since that was passing.
Ivy and NGF cells were failing since the update in KCaS, which I just set back to the previous one as in the case of CCK (and SCA)
OLM cell was failing since h ion wasn't inserted (see issue #16) - that's fixed and with conductances matching the eLife paper see bitbucket version f1bb857 it's passing again
SCA cell is the same as CCK+BC
@pgleeson Everything is passing for me!
Only one h5 based Netpyne network simulation is failing on Travis (and my machine) now... https://travis-ci.org/pgleeson/ca1/jobs/299699916
@andrisecker can you look here: https://travis-ci.org/pgleeson/ca1/jobs/272150687
The NEURON omv tests are failing, with similar errors to what I get locally. Some differences are small, but others, e.g. olm are larger: