search

mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Support Okta's response format #12

Closed fumieval closed 2 years ago

fumieval commented 2 years ago

The current version didn't work as-is because EncryptedKey is in a different location.

I changed the parser so that it accepts both KeyCloak's and Okta's responses, and added a test suite.

fumieval commented 2 years ago

@mbg ping

fumieval commented 2 years ago

I added a GitHub workflow step to run stack test

mbg commented 2 years ago

@fumieval Thanks for adding the new step to the CI and making the other changes.

In https://github.com/mbg/wai-saml2/pull/12/commits/9863e72d035b50c46255ba55a30889f202118dba, you remove a line for a case that is indeed currently redundant, but that is more a result of https://github.com/mbg/wai-saml2/blob/6d81ea83bd7a3c5ece0faee2db13d0be09ba8035/src/Network/Wai/SAML2/StatusCode.hs being incomplete, rather than the case actually being redundant. I would prefer if you drop https://github.com/mbg/wai-saml2/pull/12/commits/9863e72d035b50c46255ba55a30889f202118dba from this branch since it is unrelated to this PR and would have to be restored in the future.

fumieval commented 2 years ago

OK, I was just wondering why CI is failing and suspected that the redundant case is the cause; removed that commit for now

mbg commented 2 years ago

I commented on the CI failure in the review conversation. The file with the tests is still called parser.hs, even though you have updated package.yaml to refer to Parser.hs.

mbg commented 2 years ago

This is now released as https://hackage.haskell.org/package/wai-saml2-0.3.0.0, thank you again!

fumieval commented 2 years ago

Great, thanks!