search

mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Add a function that generates an SP initiated SSO request #19

Closed fumieval closed 1 year ago

fumieval commented 1 year ago

This PR adds a basic support for SP-initiated flow. I confirmed that it works with Google Workspace

mbg commented 1 year ago

@fumieval Thanks for your work on this and the changes you have made in response to the review. It seems that the formatting and documentation are still outstanding. Is that something you are still planning to do? If not, I can deal with the documentation and re-format the code.

fumieval commented 1 year ago

I'm afraid I'm not really sure what the issues with documentation and formatting are. Could you reformat the code?

mbg commented 1 year ago

No problem and thanks for this contribution! :) I have merged it and pushed my changes on top. You may wish to have a look over those to make sure all is good with you as well.

fumieval commented 1 year ago

Thank you for making up the documentation!