mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Add a parser for IDPSSODescriptor a.k.a. IDP metadata #20

Closed fumieval closed 1 year ago

fumieval commented 1 year ago

I implemented a parser for IdP metadata. There are a few remaining design questions; I'm open to suggestions.

fumieval commented 1 year ago

I updated the type of x509Certificate to SignedExact Certificate and added some documentation. Unfortunately I wasn't able to find specification for EntityDescriptor in HTML, so I linked to the PDF version instead

fumieval commented 1 year ago

I'll implement a datatype for NameIDFormat in a separate PR

fumieval commented 1 year ago

I updated the code style a bit. It would be nice if you could document non-standard code style requirements (such as -- | haddock syntax for record fields) in the guideline

mbg commented 1 year ago

It would be nice if you could document non-standard code style requirements

No problem, if this is helpful I can add it explicitly to the contribution guidelines.

mbg commented 1 year ago

@fumieval I have just opened #25 with some improvements (hopefully!) to the contribution guidelines. I would be grateful if you could have a look over them to see if that addresses everything you'd find useful or if anything is missing?

fumieval commented 1 year ago

Rebased to use the NameIDFormat datatype