search

mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Add NameIDFormat #21

Closed fumieval closed 1 year ago

fumieval commented 1 year ago

As mentioned in #20, I implemented a datatype for NameIDFormat, and updated the definition of Subject.

TODO: rebase after #20 is merged, or vice versa

fumieval commented 1 year ago

Updated the code/comment style

fumieval commented 1 year ago

@mbg Friendly reminder that this is ready for review

fumieval commented 1 year ago

Thank you for reviewing. I added a Haddock comment for the module

mbg commented 1 year ago

Thanks for that! You marked all the other review comments as resolved, but I don't actually see those changes in the code?

fumieval commented 1 year ago

Thanks for that! You marked all the other review comments as resolved, but I don't actually see those changes in the code?

Ah sorry, I accidentally force-pushed over the commited suggestion. Fixed now