mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Incomplete handling of `Conditions` #34

Closed Philonous closed 1 year ago

Philonous commented 1 year ago

To check the validity of an Assertion, we should also check AudienceRestrictions. (This doesn't seem to happen at the moment)

To quote [1] (lines 922 - 925)

Note that multiple elements MAY be included in a single assertion, and each MUST be evaluated independently. The effect of this requirement and the preceding definition is that within a given condition, the audiences form a disjunction (an "OR") while multiple conditions form a conjunction (an "AND").

As I understand it, this means:

I'll work on a PR

References:

Philonous commented 1 year ago