mbg / wai-saml2

WAI middleware implementing SAML2
MIT License
5 stars 6 forks source link

Support signed assertions #45

Open fumieval opened 1 year ago

fumieval commented 1 year ago

Summary

At the moment, wai-saml2 validates signed responses, but not signed assertions. This might cause an error when the identity provider signs assertions only (by default AzureAD does not sign responses). This change adds support for signed assertions; when a signature for the response is present, it validates the response. If this is missing, it validates the signature for the assertion instead.

Checklist

mbg commented 1 year ago

I haven't had the time to review this yet, but I hope to be able to do so by the end of the coming weekend at the latest. Thank you as always for your contributions and patience! 🙇🏽

fumieval commented 1 year ago

@mbg I split the tests to #52; I hope this makes reviewing easier a bit

mbg commented 2 months ago

@fumieval Do you want to update this now that #52 is merged?

fumieval commented 2 months ago

@mbg Sure. I refactored the implementation for more clarity